[Contracts] Split the global CHANGELOG in dedicated CHANGELOG per contract #35663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 10, 2020
OskarStark
approved these changes
Feb 10, 2020
javiereguiluz
approved these changes
Feb 10, 2020
fabpot
approved these changes
Feb 10, 2020
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Feb 10, 2020
…GELOG per contract (lyrixx) This PR was merged into the 5.1-dev branch. Discussion ---------- [Contracts] Split the global CHANGELOG in dedicated CHANGELOG per contract | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | --- This is more in sync with what we do with other components + bundles. And when we contribute to a contact, it's easier to find the file (because with the substree, we don't get the global package) Commits ------- a05ee08 [Constracts] Split the global CHANGELOG in dedicated CHANGELOG per contract
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Feb 13, 2020
fabpot
added a commit
that referenced
this pull request
Feb 14, 2020
… contracts (nicolas-grekas) This PR was squashed before being merged into the 5.1-dev branch. Discussion ---------- [symfony/contracts] Reference one main CHANGELOG in each contracts | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Reverts #35663 This PR makes it easier to publish the changelog for the contracts: there is only one to reference. We also need a changelog for symfony/contracts and this PR fixes this concern. Commits ------- d6fa13b [symfony/contracts] Reference one main CHANGELOG in each contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more in sync with what we do with other components + bundles.
And when we contribute to a contact, it's easier to find the file (because with the substree, we don't get the global package)