[Process] PhpProcess::fromShellCommandLine #35638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should target 4.4, isn't it? |
|
So, PhpProcess cannot be used with |
|
Correct. There is no use case for that, the implementation you provided doesn't make sense: it duplicates the existing constructor, but we don't need two ways doing the same. |
|
Ok, I understand the point, so, this method should only throw, can we use the component |
|
Would LGTM yes. |
|
Ok, sorry for the wrong branch target, I've pushed a new PR and rebased it for 4.4, I close this one. |
fabpot
added a commit
that referenced
this pull request
Feb 8, 2020
… used (Guikingone) This PR was merged into the 4.4 branch. Discussion ---------- [Process] throw when PhpProcess::fromShellCommandLine() is used | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35637 | License | MIT | Doc PR | None Close #35638 Final PR (rebased and tests added) Commits ------- 7f6d71c refactor(Process): fromShellCommandLine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone 👋
This PR fix a small issue found in
PhpProcess::fromShellCommandLine(), the fix is not big as it's only an override of the method, tests added.