Update user role restriction test cases.

symfony · gorshkov-ag · Jan 31, 2020 · Feb 3, 2020 · Feb 3, 2020 · Feb 13, 2020
commit 9de09f0cfbfed2af1f7ae0a63597171615a51ac3
diff --git a/src/Symfony/Component/Security/Core/Tests/Authentication/Token/SwitchUserTokenTest.php b/src/Symfony/Component/Security/Core/Tests/Authentication/Token/SwitchUserTokenTest.php
@@ -72,7 +72,10 @@ public function getSalt()
        $token = new SwitchUserToken($impersonated, 'bar', 'provider-key', ['ROLE_USER', 'ROLE_PREVIOUS_ADMIN'], $originalToken);
        $token->setUser($impersonated);
        $this->assertTrue($token->isAuthenticated());
+    }

+    public function testRestrictUserRolesDoesNotDeauthenticate()
+    {
        $impersonator = new class() implements UserInterface {
            public function getUsername()
            {
@@ -112,6 +115,37 @@ public function getSalt()
        $token = new SwitchUserToken($impersonator, 'foo', 'provider-key', ['ROLE_ADMIN', 'ROLE_PREVIOUS_ADMIN'], $originalToken);
        $token->setUser($impersonator);
        $this->assertTrue($token->isAuthenticated());
+    }
+
+    public function testAddUserRolesDeauthenticate()
+    {
+        $impersonator = new class() implements UserInterface {
+            public function getUsername()
+            {
+                return 'impersonator';
+            }
+
+            public function getPassword()
+            {
+                return null;
+            }
+
+            public function eraseCredentials()
+            {
+            }
+
+            public function getRoles()
+            {
+                return ['ROLE_USER', 'ROLE_ADMIN', 'ROLE_ALLOWED_TO_SWITCH'];
+            }
+
+            public function getSalt()
+            {
+                return null;
+            }
+        };
+
+        $originalToken = new UsernamePasswordToken($impersonator, 'foo', 'provider-key', ['ROLE_USER', 'ROLE_ADMIN', 'ROLE_ALLOWED_TO_SWITCH']);

        $token = new SwitchUserToken($impersonator, 'foo', 'provider-key', ['ROLE_TEST', 'ROLE_PREVIOUS_ADMIN'], $originalToken);
        $token->setUser($impersonator);