Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Mailer] Make default factories public #35519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

[Mailer] Make default factories public #35519

merged 1 commit into from
Jan 30, 2020

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jan 30, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #35469
License MIT
Doc PR symfony/symfony-docs#...

To allow registering new factories and keep the default ones available.

@fabpot fabpot mentioned this pull request Jan 30, 2020
Closed
@fabpot
Copy link
Member Author

fabpot commented Jan 30, 2020

/cc @Koc

@Koc
Copy link
Contributor

Koc commented Jan 30, 2020

Sounds reasonable

@fabpot fabpot mentioned this pull request Jan 30, 2020
Closed
fabpot added a commit that referenced this pull request Jan 30, 2020
@fabpot
feature #35519 [Mailer] Make default factories public (fabpot)
fbc3dc8 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Mailer] Make default factories public

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #35469 <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

To allow registering new factories and keep the default ones available.

Commits
-------

c9863c6 [Mailer] Make default factories public
@fabpot fabpot merged commit c9863c6 into symfony:master Jan 30, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@ilohpro
Copy link

ilohpro commented Feb 23, 2022

Hello,
I have a question please : is it possible to use this factory function to load the dsn from the current request user (in a property in fact) ?
At the moment, i can't find a way to retrieve the current user in the factory nor in the transport.
Thank you for your answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mailer] Add ability to inject additional transport factories for DSN support
6 participants
@fabpot @Koc @ilohpro @stof @chalasr @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.