-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Check for all serialization exceptions during message dec… #35480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Just a minor fix and I'll be happy to approve.
src/Symfony/Component/Messenger/Tests/Transport/Serialization/SerializerTest.php
Outdated
Show resolved
Hide resolved
Also, make sure that fabbot.io is happy. =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be merged in 4.3
Thank you @waaghals. |
…message dec… (Patrick Berenschot) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Check for all serialization exceptions during message dec… | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35446 | License | MIT Makes it so that the Messenger Serializer throws a `MessageDecodingFailedException` for any serializer exception. Commits ------- 21fffca [Messenger] Check for all serialization exceptions during message dec…
Makes it so that the Messenger Serializer throws a
MessageDecodingFailedException
for any serializer exception.