Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Messenger] Check for all serialization exceptions during message dec… #35480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2020
Merged

[Messenger] Check for all serialization exceptions during message dec… #35480

merged 1 commit into from
Jan 29, 2020

Conversation

waaghals
Copy link

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35446
License MIT

Makes it so that the Messenger Serializer throws a MessageDecodingFailedException for any serializer exception.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just a minor fix and I'll be happy to approve.

@Nyholm
Copy link
Member

Nyholm commented Jan 28, 2020

Also, make sure that fabbot.io is happy. =)

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Contributor

@Tobion Tobion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged in 4.3

@Tobion Tobion changed the base branch from 4.4 to 4.3 January 29, 2020 12:59
@Tobion
Copy link
Contributor

Tobion commented Jan 29, 2020

Thank you @waaghals.

Tobion added a commit that referenced this pull request Jan 29, 2020
…message dec… (Patrick Berenschot)

This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Check for all serialization exceptions during message dec…

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35446
| License       | MIT

Makes it so that the Messenger Serializer throws a `MessageDecodingFailedException` for any serializer exception.

Commits
-------

21fffca [Messenger] Check for all serialization exceptions during message dec…
@Tobion Tobion merged commit 21fffca into symfony:4.3 Jan 29, 2020
This was referenced Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.