Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Console] Add constants for main exit codes #35478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

[Console] Add constants for main exit codes #35478

merged 1 commit into from
Jan 29, 2020

Conversation

Chi-teck
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #35431
License MIT

@chalasr chalasr added this to the next milestone Jan 26, 2020
@Chi-teck
Copy link
Contributor Author

Can we use these constants in console's own code?

javiereguiluz
javiereguiluz approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer EXIT_ERROR instead of EXIT_FAILURE ... but "failure" seems to be the standard word for this (e.g. https://www.gnu.org/software/libc/manual/html_node/Exit-Status.html)

Thanks @Chi-teck!

@fabpot
Copy link
Member

fabpot commented Jan 27, 2020

What about just Command::SUCCESS and Command::FAILURE?
I would not use these constants in Symfony's code.

OskarStark
OskarStark reviewed Jan 28, 2020
View reviewed changes
src/Symfony/Component/Console/Command/Command.php Outdated
@@ -29,6 +29,9 @@
*/
class Command
{
const SUCCESS = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public const 👍🏻

@fabpot
Copy link
Member

fabpot commented Jan 29, 2020

Thank you @Chi-teck.

@fabpot fabpot mentioned this pull request Jan 29, 2020
Closed
@fabpot fabpot closed this in 5b38f70 Jan 29, 2020
@fabpot fabpot merged commit 5f6a1ac into symfony:master Jan 29, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@arjenm arjenm mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Console Feature Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Console] Define constants for main exit codes.
7 participants
@Chi-teck @fabpot @javiereguiluz @OskarStark @nicolas-grekas @chalasr @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.