[Mailer] Payload sent to Sendgrid doesn't include names #35184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
approved these changes
Jan 3, 2020
fabpot
approved these changes
Jan 3, 2020
|
Thank you @versgui. |
fabpot
added a commit
that referenced
this pull request
Jan 3, 2020
…ersgui) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Payload sent to Sendgrid doesn't include names | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | When we use the Sendgrid API to send an email, for fields like to, from, bcc... the endpoint expects to receive an associative array composed of an email address and a optionally a name.  https://sendgrid.com/docs/API_Reference/api_v3.html Symfony sends only the email address, even when the name is provided. I changed the code to allow the bridge to send the name when it's provided. I didn't fix it on 4.3 because Address doesn't manage names, and its constructor signature is not the same in 4.4. Commits ------- 36eeba7 [Mailer] Fix addresses management in Sendgrid API payload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use the Sendgrid API to send an email, for fields like to, from, bcc... the endpoint expects to receive an associative array composed of an email address and a optionally a name.
https://sendgrid.com/docs/API_Reference/api_v3.html
Symfony sends only the email address, even when the name is provided. I changed the code to allow the bridge to send the name when it's provided.
I didn't fix it on 4.3 because Address doesn't manage names, and its constructor signature is not the same in 4.4.