[Console][FormatterHelper] Use helper strlen statically and remove duplicated code #35141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Dec 29, 2019
| return $message; | ||
| } | ||
|
|
||
| if (false === $encoding = mb_detect_encoding($message, null, true)) { |
There was a problem hiding this comment.
I accidentally found this code that can be replaced by the helper method.
nicolas-grekas
approved these changes
Dec 30, 2019
chalasr
approved these changes
Dec 30, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 31, 2019
…and remove duplicated code (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [Console][FormatterHelper] Use helper strlen statically and remove duplicated code | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - All those helpers methods are static and are accessed with `self::` everywhere else. They are not an extension point. Commits ------- f0d227d [Console][FormatterHelper] Use helper strlen statically and remove duplicated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All those helpers methods are static and are accessed with
self::everywhere else. They are not an extension point.