Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[TwigBridge][Form] Added missing help messages in form themes #35124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

[TwigBridge][Form] Added missing help messages in form themes #35124

merged 1 commit into from
Jan 4, 2020

Conversation

cmen
Copy link
Contributor

@cmen cmen commented Dec 27, 2019 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35006
License MIT
Doc PR /

Results:
b3

b3h

b4

b4h

f

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Dec 28, 2019
@nicolas-grekas nicolas-grekas changed the title [TwigBridge][Form] Added missing help messages for checkboxes in 3 th… [TwigBridge][Form] Added missing help messages for checkboxes in 3 themes Dec 28, 2019
xabbuh
xabbuh reviewed Jan 1, 2020
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the radio_row block in bootstrap_3_layout.html.twig and foundation_5_layout.html.twig too?

@cmen cmen changed the title [TwigBridge][Form] Added missing help messages for checkboxes in 3 themes [TwigBridge][Form] Added missing help messages in form themes Jan 1, 2020
@cmen
Copy link
Contributor Author

cmen commented Jan 1, 2020

@xabbuh
You're right. Help messages were missing for radio rows too. PR updated !

nicolas-grekas added a commit that referenced this pull request Jan 4, 2020
@nicolas-grekas
bug #35124 [TwigBridge][Form] Added missing help messages in form the…
cbf2abd 
…mes (cmen)

This PR was merged into the 4.3 branch.

Discussion
----------

[TwigBridge][Form] Added missing help messages in form themes

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35006
| License       | MIT
| Doc PR        | /

Results:
![b3](https://user-images.githubusercontent.com/8505069/71522117-a9292080-28c3-11ea-86cd-0f257d50267d.png)

![b3h](https://user-images.githubusercontent.com/8505069/71522118-acbca780-28c3-11ea-95d7-9931442160dd.png)

![b4](https://user-images.githubusercontent.com/8505069/71522119-af1f0180-28c3-11ea-8559-02f69efcd2ef.png)

![b4h](https://user-images.githubusercontent.com/8505069/71522121-b219f200-28c3-11ea-86d7-abd192ed33ad.png)

![f](https://user-images.githubusercontent.com/8505069/71522126-b5ad7900-28c3-11ea-8300-3b52258da84b.png)

Commits
-------

5374d4f [TwigBridge][Form] Added missing help messages in form themes
@nicolas-grekas nicolas-grekas merged commit 5374d4f into symfony:4.3 Jan 4, 2020
@nicolas-grekas
Copy link
Member

Thank you @cmen

@cmen cmen deleted the ticket_35006 branch January 4, 2020 14:26
This was referenced Jan 21, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Form Status: Reviewed TwigBridge
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@cmen @nicolas-grekas @xabbuh @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.