[Console] Fix filtering out identical alternatives when there is a command loader #35094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
requested changes
Dec 24, 2019
d59cc1b to
526a875
Compare
526a875 to
589e93e
Compare
|
Good catch, thanks @fancyweb. |
chalasr
added a commit
that referenced
this pull request
Dec 24, 2019
…ere is a command loader (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Fix filtering out identical alternatives when there is a command loader | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #35089 | License | MIT | Doc PR | - CommandLoader commands needs to be loaded to resolve their names and filter them. Commits ------- 589e93e [Console] Fix filtering out identical alternatives when there is a command loader
This was referenced Jan 21, 2020
Merged
Merged
Merged
Merged
|
After updating from 4.3.9 to 4.3.10 this change leads to loading of lazy commands even if they are not called. This occurs with commands where the first part of the name matches. For example if you have two lazy commands |
|
Hello, please create a new issue with a reproducer so someone can check it and start working on a fix if there was a regression. Thanks 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandLoader commands needs to be loaded to resolve their names and filter them.