[Profiler] wording #35016
Merged
[Profiler] wording #35016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Dec 17, 2019
yceruto
approved these changes
Dec 17, 2019
|
I don't see anything wrong in the current naming. |
|
😁
if we consider "database" a more sophisticated system evolving around data, id say the implementation indeed relies on a storage system, not a database system. |
|
@fabpot just to name thing as they are :) |
|
I agree that "database" looks wrong because we don't have a database here ... but what about removing any details about the storage? Original: This PR: Proposal: |
|
We can yes 👍🏻 The main idea behind was to dissociate with the database word, as a newcomer may search for nothing the profiler table data inside its database, for example like the messenger table, but for nothing :) |
f7cb466 to
c7761d9
Compare
| @@ -4,7 +4,7 @@ | ||
| 'no_token' : { | ||
| status: 'error', | ||
| title: (token|default('') == 'latest') ? 'There are no profiles' : 'Token not found', | ||
| message: (token|default('') == 'latest') ? 'No profiles found in the database.' : 'Token "' ~ token|default('') ~ '" was not found in the database.' | ||
| message: (token|default('') == 'latest') ? 'No profiles found.' : 'Token "' ~ token|default('') ~ '" was not found.' |
c7761d9 to
b97d2f7
Compare
fabpot
approved these changes
Dec 27, 2019
|
Thank you @noniagriconomie. |
b97d2f7 to
e7c9a28
Compare
fabpot
added a commit
that referenced
this pull request
Dec 27, 2019
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #35016). Discussion ---------- [Profiler] wording | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none Small wording improvement Commits ------- e7c9a28 [Profiler] wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small wording improvement