Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DX] [Workflow] Added a way to specify a message when blocking a transition + better default message in case it is not set #34573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2019
Merged

[DX] [Workflow] Added a way to specify a message when blocking a transition + better default message in case it is not set #34573

merged 1 commit into from
Nov 24, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Nov 24, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #34466
License MIT
Doc PR

@carsonbot carsonbot added Status: Needs Review DX DX = Developer eXperience (anything that improves the experience of using Symfony) Workflow labels Nov 24, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Nov 24, 2019
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 24, 2019
Closed
@lyrixx lyrixx force-pushed the workflow-set-blocked branch 2 times, most recently from cf237d9 to 2554de0 Compare November 24, 2019 18:00
@lyrixx
[Workflow] Added a way to specify a message when blocking a transitio…
169bb2f 
…n + better default message in case it is not set
@lyrixx lyrixx force-pushed the workflow-set-blocked branch from 2554de0 to 169bb2f Compare November 24, 2019 18:02
@fabpot
Copy link
Member

fabpot commented Nov 24, 2019

Thank you @lyrixx.

@fabpot fabpot mentioned this pull request Nov 24, 2019
Closed
fabpot added a commit that referenced this pull request Nov 24, 2019
@fabpot
feature #34573 [DX] [Workflow] Added a way to specify a message when …
adbc1df 
…blocking a transition + better default message in case it is not set (lyrixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[DX] [Workflow] Added a way to specify a message when blocking a transition + better default message in case it is not set

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34466
| License       | MIT
| Doc PR        |

Commits
-------

169bb2f [Workflow] Added a way to specify a message when blocking a transition + better default message in case it is not set
@fabpot fabpot merged commit 169bb2f into symfony:master Nov 24, 2019
@lyrixx lyrixx deleted the workflow-set-blocked branch November 24, 2019 18:37
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) Status: Reviewed Workflow
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @fabpot @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.