-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Remove wrong @group legacy annotations #34433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
but it doesn't throw on 5.0
that's the only other failure triggered by this change. This means we should have a look twice at these two tests on master, and we should remove all the other annotations since they're not covering any deprecations. Anyone? |
@@ -62,9 +62,6 @@ public function getBadResourceStrings() | ||
]; | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should be removed here and on master 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2801b66
to
09f4d07
Compare
@nicolas-grekas Looks like we will have to apply https://github.com/symfony/symfony/pull/34434/files#diff-40e4c90663826378950ff96dce5b445eR55 on 4.4 as well or skip the test. |
applied |
09f4d07
to
8d84ac3
Compare
@@ -60,8 +60,6 @@ public function getDebugModes() | ||
} | ||
|
||
/** | ||
* @group legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this was missed in #33507 where the deprecation of the intercept_redirects
option was reverted.
@@ -142,8 +142,6 @@ public function getToolbarConfig() | ||
} | ||
|
||
/** | ||
* @group legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this was missed in #33507 where the deprecation of the intercept_redirects
option was reverted.
This PR was merged into the 4.4 branch. Discussion ---------- Remove wrong @group legacy annotations | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - These annotations are still found on branch 5.0. Does this mean they are wrong? Why don't they make 5.0 fail if not? Commits ------- 8d84ac3 Remove wrong @group legacy annotations
These annotations are still found on branch 5.0.
Does this mean they are wrong? Why don't they make 5.0 fail if not?