[WebProfilerBundle] Require symfony/twig-bundle #34381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Nov 14, 2019
|
It can break Silex. I know, it's not maintained anymore, but that's just an example. |
The |
|
|
Sorry, my comment is not on the right PR :) It should have been on #34389 |
fabpot
approved these changes
Nov 15, 2019
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Nov 15, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [WebProfilerBundle] Require symfony/twig-bundle | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Starting from a fresh 3.4 I did `composer require symfony/web-profiler-bundle --dev` but it fails on post install cache clear because https://github.com/symfony/symfony/blob/8a68d2d358ae7db406f72711c24d5c8f687cf7b6/src/Symfony/Bundle/WebProfilerBundle/Resources/config/profiler.xml#L13 needs the `twig` service that is declared in the `TwigBundle`. `symfony/twig-bundle` is already a hard depency of the `WebProfilerBundle` on 4.3+ (cf cac37ca). Commits ------- 78dad79 [WebProfilerBundle] Require symfony/twig-bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from a fresh 3.4 I did
composer require symfony/web-profiler-bundle --devbut it fails on post install cache clear becausesymfony/src/Symfony/Bundle/WebProfilerBundle/Resources/config/profiler.xml
Line 13 in 8a68d2d
twigservice that is declared in theTwigBundle.symfony/twig-bundleis already a hard depency of theWebProfilerBundleon 4.3+ (cf cac37ca).