[HttpFoundation] Allow redirecting to URLs that contain a semicolon #34366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, that's for branch 3.4 I suppose. |
317b27a to
c5f8147
Compare
nicolas-grekas
approved these changes
Nov 17, 2019
c5f8147 to
bd0637e
Compare
fabpot
approved these changes
Nov 17, 2019
|
Thank you @JayBizzle. |
fabpot
added a commit
that referenced
this pull request
Nov 17, 2019
…semicolon (JayBizzle) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Allow redirecting to URLs that contain a semicolon | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT URLs that contain a semicolon cannot be redirected to at least in MS Edge and IE10. Take the following example... ``` # https://ad.doubleclick.net/ddm/clk/450721234;254801234;l // After redirect... # https://ad.doubleclick.net/ddm/clk/450721234 ``` Wrapping the URL in single quotes fixes the issue ([related reading](https://www.w3.org/TR/WCAG20-TECHS/H76.html)) Commits ------- bd0637e [HttpFoundation] Allow redirecting to URLs that contain a semicolon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs that contain a semicolon cannot be redirected to at least in MS Edge and IE10.
Take the following example...
Wrapping the URL in single quotes fixes the issue (related reading)