Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Cache] fixed TagAwareAdapter returning invalid cache #33962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2019

Conversation

v-m-i
Copy link
Contributor

@v-m-i v-m-i commented Oct 11, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33953
License MIT
Doc PR

This PR fixes TagAwareAdapter returning CacheItem when item-tags pair is missing tag key in pool. Currently TagAwareAdapter returns CacheItem with empty tags and isHit set to true. With this PR it returns CacheItem with isHit set to false as we can't know if item is valid or invalid when it's missing tag entry so we treat it as cache miss.

@nicolas-grekas
Copy link
Member

Thank you @v-m-i.

nicolas-grekas added a commit that referenced this pull request Oct 12, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] fixed TagAwareAdapter returning invalid cache

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33953
| License       | MIT
| Doc PR        |

This PR fixes `TagAwareAdapter` returning `CacheItem` when item-tags pair is missing tag key in pool. Currently `TagAwareAdapter` returns `CacheItem` with empty tags and `isHit` set to `true`. With this PR it returns `CacheItem` with `isHit` set to `false` as we can't know if item is valid or invalid when it's missing tag entry so we treat it as cache miss.

Commits
-------

946f0a1 [Cache] fixed TagAwareAdapter returning invalid cache
@nicolas-grekas nicolas-grekas merged commit 946f0a1 into symfony:3.4 Oct 12, 2019
@v-m-i
Copy link
Contributor Author

v-m-i commented Oct 12, 2019

@nicolas-grekas You’re welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.