[Cache] fixed TagAwareAdapter returning invalid cache #33962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a23b2c3 to
946f0a1
Compare
nicolas-grekas
approved these changes
Oct 12, 2019
|
Thank you @v-m-i. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 12, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Cache] fixed TagAwareAdapter returning invalid cache | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33953 | License | MIT | Doc PR | This PR fixes `TagAwareAdapter` returning `CacheItem` when item-tags pair is missing tag key in pool. Currently `TagAwareAdapter` returns `CacheItem` with empty tags and `isHit` set to `true`. With this PR it returns `CacheItem` with `isHit` set to `false` as we can't know if item is valid or invalid when it's missing tag entry so we treat it as cache miss. Commits ------- 946f0a1 [Cache] fixed TagAwareAdapter returning invalid cache
|
@nicolas-grekas You’re welcome |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
TagAwareAdapterreturningCacheItemwhen item-tags pair is missing tag key in pool. CurrentlyTagAwareAdapterreturnsCacheItemwith empty tags andisHitset totrue. With this PR it returnsCacheItemwithisHitset tofalseas we can't know if item is valid or invalid when it's missing tag entry so we treat it as cache miss.