Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Messenger] Store message body as a blob object, not text #33920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Messenger] Store message body as a blob object, not text #33920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a60a0ae
Store message body as a blob object, not text
rimas-kudelis Oct 9, 2019
6a3b3e4
Hint message body as Type::BLOB
Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public function send(string $body, array $headers, int $delay = 0): string
$now,
$availableAt,
], [
null,
Type::BLOB,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right thing to do. But someone needs to test if it keeps working for people that still have the text type. So can you insert non-binary data to the body column if it is of type text (before this change)? Otherwise this PR would be a bc break.

null,
null,
Type::DATETIME,
Expand Down Expand Up @@ -318,7 +318,7 @@ private function getSchema(): Schema
$table->addColumn('id', Type::BIGINT)
->setAutoincrement(true)
->setNotnull(true);
$table->addColumn('body', Type::TEXT)
$table->addColumn('body', Type::BLOB)
->setNotnull(true);
$table->addColumn('headers', Type::TEXT)
->setNotnull(true);
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.