something else we may want to consider, and what we did for DI configurators as well, is to make it truly fluid;

$optionsResolver
    ->define('foo')
        ->required()
    ->define('bar')
        ->required()
;

@lmillucci thanks for your work and for solving all comments.

After the discussion we had about this #33848 (comment) where I suggest you to remove the annotation @return $this, I think we should add it again now, because it should help make it clear that it is a fluent interface by saying that each method will return the same instance of the class $this, except for the define() method that will return a new instance.

I'm sorry about that, and I hope you're okay.

@yceruto no problem, I've easily restored @return $this annotation for all methods except define()

@stof could you please review this PR again and have your vote on this ? thanks!

ping @symfony/mergers ?

Ready for final reviews (the fabbot.io failure is a false positive)

@lmillucci do you like to finish this proposal?

@lmillucci do you like to finish this proposal?

@yceruto Yes, what exception should be thrown when defining an already defined option? Something like OptionDefinitionException should be ok?

@lmillucci yes, OptionDefinitionException would be ok.

@lmillucci almost done :) you just need to rebase on master branch to make it ready for Symfony 5.1

there is a commit that don't belongs to this PR f825642 (the first one) could you please, fix it? thanks!

The component's CHANGELOG file should mention this change.

Thank you @lmillucci.