Fix the :only-of-type pseudo class selector #33777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
Sep 30, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #33773 |
| License | MIT |
| Doc PR | - |
53864f1 to
988405c
Compare
jakzal
commented
Sep 30, 2019
| @@ -116,7 +116,7 @@ public function testHtmlIds($css, array $elementsId) | ||
| $this->assertCount(\count($elementsId), $elementsId); | ||
| foreach ($elements as $element) { | ||
| if (null !== $element->attributes()->id) { | ||
| $this->assertTrue(\in_array($element->attributes()->id, $elementsId)); | ||
| $this->assertContains((string) $element->attributes()->id, $elementsId); |
There was a problem hiding this comment.
This is not strictly related, but it improves an error message shown when the test fails. Before the change, the message would say "expected true, got false". Now it will indicate what's the missing id.
9bfc715 to
bd314d3
Compare
stof
approved these changes
Oct 1, 2019
fabpot
approved these changes
Oct 1, 2019
bd314d3 to
c2a9bf0
Compare
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Oct 1, 2019
This PR was squashed before being merged into the 3.4 branch (closes #33777). Discussion ---------- Fix the :only-of-type pseudo class selector | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33773 | License | MIT | Doc PR | - Commits ------- c2a9bf0 Fix the :only-of-type pseudo class selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.