Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add missing row_attr option to FormType #33688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Add missing row_attr option to FormType #33688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions 3 src/Symfony/Component/Form/Extension/Core/Type/BaseType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ public function buildView(FormView $view, FormInterface $form, array $options)
'attr' => $options['attr'],
'block_prefixes' => $blockPrefixes,
'unique_block_prefix' => $uniqueBlockPrefix,
'row_attr' => $options['row_attr'],
'translation_domain' => $translationDomain,
'label_translation_parameters' => $labelTranslationParameters,
'attr_translation_parameters' => $attrTranslationParameters,
Expand All @@ -125,6 +126,7 @@ public function configureOptions(OptionsResolver $resolver)
'disabled' => false,
'label' => null,
'label_format' => null,
'row_attr' => [],
'label_translation_parameters' => [],
'attr_translation_parameters' => [],
'attr' => [],
Expand All @@ -134,5 +136,6 @@ public function configureOptions(OptionsResolver $resolver)

$resolver->setAllowedTypes('block_prefix', ['null', 'string']);
$resolver->setAllowedTypes('attr', 'array');
$resolver->setAllowedTypes('row_attr', 'array');
}
}
1 change: 1 addition & 0 deletions 1 src/Symfony/Component/Form/Tests/Fixtures/Descriptor/resolved_form_type_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"post_max_size_message",
"property_path",
"required",
"row_attr",
"translation_domain",
"upload_max_size_message"
]
Expand Down
1 change: 1 addition & 0 deletions 1 src/Symfony/Component/Form/Tests/Fixtures/Descriptor/resolved_form_type_1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Symfony\Component\Form\Extension\Core\Type\ChoiceType (Block prefix: "choice")
post_max_size_message
property_path
required
row_attr
translation_domain
upload_max_size_message
--------------------------- -------------------- ------------------------------ -----------------------
Expand Down
1 change: 1 addition & 0 deletions 1 src/Symfony/Component/Form/Tests/Fixtures/Descriptor/resolved_form_type_2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"post_max_size_message",
"property_path",
"required",
"row_attr",
"translation_domain",
"trim",
"upload_max_size_message"
Expand Down
1 change: 1 addition & 0 deletions 1 src/Symfony/Component/Form/Tests/Fixtures/Descriptor/resolved_form_type_2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Symfony\Component\Form\Extension\Core\Type\FormType (Block prefix: "form")
post_max_size_message
property_path
required
row_attr
translation_domain
trim
upload_max_size_message
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.