[HttpClient] fix throwing HTTP exceptions when the 1st chunk is emitted #33643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2019
…nk is emitted (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] fix throwing HTTP exceptions when the 1st chunk is emitted | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Spotted while discussing the client with @Seldaek The current behavior is transient: depending on the speed of the network/server, the exception can be thrown, or not. This forces one do deal with 3/4/5xx when the first chunk is yielded. Commits ------- 3c93764 [HttpClient] fix throwing HTTP exceptions when the 1st chunk is emitted
stof
reviewed
Sep 20, 2019
| @@ -152,6 +152,16 @@ public function testClientError() | ||
| $this->assertSame(404, $response->getStatusCode()); | ||
| $this->assertSame(['application/json'], $response->getHeaders(false)['content-type']); | ||
| $this->assertNotEmpty($response->getContent(false)); | ||
|
|
||
| $response = $client->request('GET', 'http://localhost:8057/404'); |
There was a problem hiding this comment.
could we create separate tests rather than a single test testClientError actually performing multiple subsequent tests ? This would allow each test name to describe what it is testing.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while discussing the client with @Seldaek
The current behavior is transient: depending on the speed of the network/server, the exception can be thrown, or not.
This forces one do deal with 3/4/5xx when the first chunk is yielded.