[HttpClient] Add default value for Accept header #33601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c61c18 to
61873fe
Compare
|
Could you please have a look at the test case that fails in relation to this change? |
61873fe to
31b5248
Compare
31b5248 to
48eebfc
Compare
nicolas-grekas
approved these changes
Sep 16, 2019
fabpot
approved these changes
Sep 17, 2019
|
Thank you @numerogeek. |
fabpot
added a commit
that referenced
this pull request
Sep 17, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] Add default value for Accept header | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #33596 <!-- prefix each issue number with "Fix #", if any --> | License | MIT This PR will add an "Accept: *" header when nothing is provided to stick with the behavior of a native curl query or postman query. Commits ------- 48eebfc Add default value for Accept header
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add an "Accept: *" header when nothing is provided to stick with the behavior of a native curl query or postman query.