[HttpClient] improve handling of HTTP/2 PUSH, disable it by default #33444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d20fdd to
f5b9d3a
Compare
stof
reviewed
Sep 3, 2019
f5b9d3a to
ea0c174
Compare
fabpot
reviewed
Sep 3, 2019
ea0c174 to
3e56bdf
Compare
stof
reviewed
Sep 3, 2019
| @@ -50,24 +50,19 @@ public function log($level, $message, array $context = []) | ||
| $client = new CurlHttpClient(); |
There was a problem hiding this comment.
shouldn't this test be updated to opt-in for push, now that it is disabled by default ?
There was a problem hiding this comment.
sure, fixed
note that the test doesn't work, but we skip it
I prefer keeping it this way so that we are reminded about it in the future :)
3e56bdf to
019bce7
Compare
nicolas-grekas
commented
Sep 3, 2019
| @@ -120,9 +120,6 @@ public function __construct(CurlClientState $multi, $ch, array $options = null, | ||
|
|
||
| if (\in_array($waitFor, ['headers', 'destruct'], true)) { | ||
| try { | ||
| if (\defined('CURLOPT_STREAM_WEIGHT')) { | ||
| curl_setopt($ch, CURLOPT_STREAM_WEIGHT, 32); |
There was a problem hiding this comment.
this closes #32529
nicolas-grekas
added a commit
that referenced
this pull request
Sep 3, 2019
…y default (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] improve handling of HTTP/2 PUSH, disable it by default | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This follows discussions with @dunglas For the test cases, https://http2-push.io is down, let's use Akamai instead This PR now considers the proxy settings before accepting a pushed response. It also splits the responsibility of dealing with accepting pushed responses in method `acceptPushForRequest`. The logic in this method could also be delegated to a userland callback passed as an option. Let's wait for someone with an actual use case before adding the option. This PR also disables HTTP/2 PUSH by default because it is not stable: locally, with the latest curl version, enabling this on a server that pushes things fails with `Failure when receiving data from the peer`. This is not ready for prime time in either ext-curl or the underlying libcurl. You can still enable it explicitly by passing some positive number to the constructor. Commits ------- 019bce7 [HttpClient] improve handling of HTTP/2 PUSH
nicolas-grekas
added a commit
that referenced
this pull request
Sep 3, 2019
…ndled properly (dunglas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] Fix a bug preventing Server Pushes to be handled properly | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Follows #33444. Commits ------- e1fbaeb [HttpClient] Fix a bug preventing Server Pushes to be handled properly
|
Thank you |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 11, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] Re-enable Server Push support | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | n/a #33444 disabled Server Push support for the CURL implementation, but `HttpClient::create()` has been forgotten and override this parameter, consequently for most users Server Push wasn't disabled at all. The root issue affecting the tests are actually a misconfiguration of Akamai servers (we need our own test infrastructure). According to my testing, Server Push support works very smoothly. Also, it can cause problems only if the server actually pushes responses (which is still rare). So I propose to re-enable Push Support everywhere. Commits ------- 8483842 Re-enable push support for HttpClient
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows discussions with @dunglas
For the test cases, https://http2-push.io is down, let's use Akamai instead
This PR now considers the proxy settings before accepting a pushed response.
It also splits the responsibility of dealing with accepting pushed responses in method
acceptPushForRequest.The logic in this method could also be delegated to a userland callback passed as an option. Let's wait for someone with an actual use case before adding the option.
This PR also disables HTTP/2 PUSH by default because it is not stable: locally, with the latest curl version, enabling this on a server that pushes things fails with
Failure when receiving data from the peer. This is not ready for prime time in either ext-curl or the underlying libcurl. You can still enable it explicitly by passing some positive number to the constructor.