Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix #33395 PHP 5.3 compatibility #33396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

Fix #33395 PHP 5.3 compatibility #33396

merged 1 commit into from
Aug 30, 2019

Conversation

kylekatarnls
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33395
License MIT

@michaljusiega
Copy link
Contributor

The minimum version of SF 3.4 isn't PHP 5.3 or I forgot something?

@kylekatarnls
Copy link
Contributor Author

The minimum compatibility of symfony/phpunit-bridge is PHP 5.3

@kylekatarnls
Copy link
Contributor Author

I used ^3.4 in my Travis-CI test for PHP 5.3 and it suddenly broke with the version 3.4.31.

@fabpot
Copy link
Member

fabpot commented Aug 30, 2019

Thank you @kylekatarnls.

fabpot added a commit that referenced this pull request Aug 30, 2019
@fabpot
bug #33396 Fix #33395 PHP 5.3 compatibility (kylekatarnls)
87c8d2d 
This PR was merged into the 3.4 branch.

Discussion
----------

Fix #33395 PHP 5.3 compatibility

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #33395
| License       | MIT

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

dede158 Fix #33395 PHP 5.3 compatibility
@fabpot fabpot merged commit dede158 into symfony:3.4 Aug 30, 2019
@kylekatarnls kylekatarnls deleted the patch-2 branch August 30, 2019 18:07
@kylekatarnls
Copy link
Contributor Author

A pleasure to help as it's a pleasure to use Symfony.

This was referenced Oct 7, 2019
Merged
Merged
@fmonts
Copy link

fmonts commented Oct 8, 2019

Supporting EOL PHP versions should be considered a security vulnerability and fixed IMHO

@stof
Copy link
Member

stof commented Oct 8, 2019

@fmonts symfony/phpunit-bridge is about running tests. Allowing other projects supporting these PHP versions to use our uptodate test tool is actually reducing our maintenance burden.
And being a test tooling, the argument of PHP 5.3 being unmaintained and so being insecure does not hold (you won't use symfony/phpunit-bridge in production)

@fmonts
Copy link

fmonts commented Oct 8, 2019

hmm ok, it was just strange to read this commit message in the 4.3 changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kylekatarnls @michaljusiega @fabpot @fmonts @stof @derrabus @xabbuh @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.