[HttpKernel] do not mock removed getPublicDir() method #33336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 26, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
stof
reviewed
Aug 26, 2019
| @@ -626,7 +626,7 @@ protected function getBundle($dir = null, $parent = null, $className = null, $bu | ||
| { | ||
| $bundle = $this | ||
| ->getMockBuilder('Symfony\Component\HttpKernel\Bundle\BundleInterface') | ||
| ->setMethods(['getPath', 'getPublicDir', 'getParent', 'getName']) | ||
| ->setMethods(['getPath', 'getParent', 'getName']) |
There was a problem hiding this comment.
It's only deprecated and will be removed in 5.0, right?
There was a problem hiding this comment.
deprecated in 3.4 and removed in 4.0
nicolas-grekas
approved these changes
Aug 26, 2019
yceruto
approved these changes
Aug 26, 2019
|
Thank you @xabbuh. |
yceruto
added a commit
that referenced
this pull request
Aug 26, 2019
…xabbuh) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] do not mock removed getPublicDir() method | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 54cb471 do not mock removed getPublicDir() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.