[HttpKernel] Bump dependencies and apply upstream parameter types #33192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests red. |
66daaeb to
5378e62
Compare
derrabus
commented
Aug 16, 2019
| @@ -33,7 +33,7 @@ public function __construct($paths = []) | ||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function locate(string $name, string $currentPath = null, $first = true) | ||
| public function locate(string $name, string $currentPath = null, bool $first = true) |
|
Remaining failures are unrelated. |
5378e62 to
aa0fc6f
Compare
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 19, 2019
…ter types (derrabus) This PR was merged into the 5.0-dev branch. Discussion ---------- [HttpKernel] Bump dependencies and apply upstream parameter types | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A This PR bumps some dependencies of the HttpKernel component in order to apply parameter type declarations. Commits ------- aa0fc6f [HttpKernel] Bump dependencies and apply upstream parameter types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps some dependencies of the HttpKernel component in order to apply parameter type declarations.