add unit-test for parse with modifier

symfony · Alexander1000 · Aug 1, 2019 · Aug 3, 2019 · Aug 3, 2019 · Aug 3, 2019
commit 5a5bf1884b588ef088e60fe1dac7efe4b0735b2f
@@ -668,9 +668,9 @@ private function parseValue(string $value, int $flags, string $context)
        }

        if (\in_array($value[0], ['!', '|', '>'], true) && self::preg_match('/^(?:'.self::TAG_PATTERN.' +)?'.self::BLOCK_SCALAR_HEADER_PATTERN.'$/', $value, $matches)) {
-            $modifiers = isset($matches['modifiers']) ? $matches['modifiers'] : 0;
+            $modifiers = isset($matches['modifiers']) ? $matches['modifiers'] : '';

-            $data = $this->parseBlockScalar($matches['separator'], preg_replace('#\d+#', '', $modifiers), (int) abs($modifiers));
+            $data = $this->parseBlockScalar($matches['separator'], preg_replace('#\d+#', '', $modifiers), (int) abs((int) $modifiers));

            if ('' !== $matches['tag'] && '!' !== $matches['tag']) {
                if ('!!binary' === $matches['tag']) {

@@ -2167,6 +2167,28 @@ public function testMultiLineComment()

        $this->assertSame(['parameters' => 'abc'], $this->parser->parse($yaml));
    }
+
+    public function testParseValueWithModifiers()
+    {
+        $yaml = <<<YAML
+parameters:
+    abc: |+5 # plus five spaces indent
+         one
+         two
+         three
+         four
+         five
+YAML;
+
+        $this->assertSame(
+            [
+                'parameters' => [
+                    'abc' => implode(PHP_EOL, ['one', 'two', 'three', 'four', 'five']),
+                ]
+            ],
+            $this->parser->parse($yaml)
+        );
+    }
 }

 class B
@@ -2176,4 +2198,6 @@ class B
    const FOO = 'foo';
    const BAR = 'bar';
    const BAZ = 'baz';
+
+    const DELTA = 3;
 }