Make tests support phpunit 8 #32842
Merged
Make tests support phpunit 8 #32842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88e284d to
144abeb
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 31, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Make tests support phpunit 8 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Having `void` on setUp/tearDown is **really** painful /cc @sebastianbergmann FYI This works around the issue by adding a new trait to the phpunit-bridge: `SetUpTearDownTrait`. Another reason why the bridge is so useful... With this change, we should have the same codebase be able to run under phpunit 4.8 (used with PHP5.5) up to phpunit 8.2 (used with PHP7.4). :crossed_fingers: :face_with_head_bandage: One more step towards PHP 7.4 support. Commits ------- 81af97f Make tests support phpunit 8
23 tasks
|
This looks like a huge source of conflicts. Are we sure we want to introduce that? The alternatives would be to not support phpunit 8 or only do these changes in 4.4 and up. |
|
This is merged up to master now so that conflicts are resolved once for all. We have to support phpunit 8 because that's the only way to PHP 7.4, which we want to support on branch 3.4... |
This is a recurring problem: every PHPUnit version supports just a small range of PHP versions. |
teohhanhui
reviewed
Aug 29, 2019
| @@ -32,6 +32,11 @@ abstract class KernelTestCase extends TestCase | ||
| */ | ||
| protected static $kernel; | ||
|
|
||
| private function doTearDown() |
There was a problem hiding this comment.
Maybe it doesn't bother too many people, but the visibility of this method has been changed from v4.3.3:
It broke our builds in API Platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
voidon setUp/tearDown is really painful /cc @sebastianbergmann FYIThis works around the issue by adding a new trait to the phpunit-bridge :
ForwardCompatTestTrait.Another reason why the bridge is so useful...
With this change, we should have the same codebase be able to run under phpunit 4.8 (used with PHP5.5) up to phpunit 8.2 (used with PHP7.4).
🤞 🤕
One more step towards PHP 7.4 support.