[SecurityBundle] add parameter type declarations where possible #32778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 27, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | part of #32179 |
| License | MIT |
| Doc PR |
57 tasks
chalasr
approved these changes
Jul 27, 2019
d3d82fe to
d1032b7
Compare
Tobion
suggested changes
Jul 28, 2019
src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/AbstractFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RemoteUserFactory.php
Outdated
Show resolved
Hide resolved
d1032b7 to
2d5ccc3
Compare
2d5ccc3 to
fde09a2
Compare
|
Status: Needs Review |
Tobion
approved these changes
Jul 29, 2019
|
Thank you @xabbuh. |
Tobion
added a commit
that referenced
this pull request
Jul 29, 2019
…ossible (xabbuh) This PR was merged into the 5.0-dev branch. Discussion ---------- [SecurityBundle] add parameter type declarations where possible | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | part of #32179 | License | MIT | Doc PR | Commits ------- fde09a2 add parameter type declarations where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.