Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[TwigBridge] add parameter type declarations where possible #32774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2019
Merged

[TwigBridge] add parameter type declarations where possible #32774

merged 1 commit into from
Jul 28, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 27, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets part of #32179
License MIT
Doc PR

@xabbuh xabbuh added this to the 5.0 milestone Jul 27, 2019
@xabbuh xabbuh requested a review from lyrixx as a code owner July 27, 2019 10:04
@xabbuh xabbuh force-pushed the issue-32179-twig-bridge branch 3 times, most recently from e4d227f to 07d80a5 Compare July 27, 2019 10:09
@derrabus derrabus mentioned this pull request Jul 27, 2019
Closed
57 tasks
@xabbuh xabbuh force-pushed the issue-32179-twig-bridge branch from 07d80a5 to f140732 Compare July 27, 2019 10:38
Tobion
Tobion reviewed Jul 27, 2019
View reviewed changes
src/Symfony/Bridge/Twig/Command/DebugCommand.php Outdated Show resolved Hide resolved
@xabbuh xabbuh force-pushed the issue-32179-twig-bridge branch from f140732 to b9fa515 Compare July 28, 2019 07:06
@Tobion
Copy link
Contributor

Tobion commented Jul 28, 2019

Thank you @xabbuh.

@Tobion Tobion merged commit b9fa515 into symfony:master Jul 28, 2019
Tobion added a commit that referenced this pull request Jul 28, 2019
@Tobion
minor #32774 [TwigBridge] add parameter type declarations where possi…
f545ba1 
…ble (xabbuh)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[TwigBridge] add parameter type declarations where possible

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #32179
| License       | MIT
| Doc PR        |

Commits
-------

b9fa515 add parameter type declarations where possible
@xabbuh xabbuh deleted the issue-32179-twig-bridge branch July 28, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Tobion approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

Assignees
No one assigned
Labels
Status: Reviewed TwigBridge
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @Tobion @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.