Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Routing][FrameworkBundle] Remove deprecated ServiceRouterLoader, ObjectRouteLoader and routing.loader.service #32697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets è
License MIT
Doc PR -

Remove deprecations from #32582

@fabpot
Copy link
Member

fabpot commented Jul 24, 2019

Thank you @fancyweb.

@fabpot fabpot merged commit 4dc9ff6 into symfony:master Jul 24, 2019
fabpot added a commit that referenced this pull request Jul 24, 2019
…erLoader, ObjectRouteLoader and routing.loader.service (fancyweb)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Routing][FrameworkBundle] Remove deprecated ServiceRouterLoader, ObjectRouteLoader and routing.loader.service

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | è
| License       | MIT
| Doc PR        | -

Remove deprecations from #32582

Commits
-------

4dc9ff6 [Routing][FrameworkBundle] Remove deprecated ServiceRouterLoader, ObjectRouteLoader and routing.loader.service
@fancyweb fancyweb deleted the remove-deprecated-routing-route-loaders branch July 24, 2019 11:18
Tobion added a commit that referenced this pull request Aug 17, 2019
…(derrabus)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Routing] Remove orphaned TestObjectRouteLoader fixture

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

This PR removes a fixture that was used by tests that have been removed by #32697.

Commits
-------

9f76c5d Remove orphaned TestObjectRouteLoader fixture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.