[Lock] remove usage of the StoreInterface #32558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df7c992 to
95f42cf
Compare
95f42cf to
27a7eaf
Compare
stof
reviewed
Jul 16, 2019
| @@ -28,7 +28,7 @@ class Factory implements LoggerAwareInterface | ||
|
|
||
| private $store; | ||
|
|
||
| public function __construct(StoreInterface $store) | ||
| public function __construct(PersistStoreInterface $store) |
There was a problem hiding this comment.
Does it actually make sense to change the typehint of the deprecated class ? It will also be removed in 5.0 at the same time than the StoreInterface anyway.
|
It closed the PR see #32562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR according to the review of @nicolas-grekas in #32555 (comment).