[Bundles] Rename getPublicPath() as getPublicDir() #32452
Conversation
|
One difference though is that |
|
I haven't thought about that 🤔 To me, "dir" can mean both relative and absolute, such as in this example:
But if this is confusing to people, we can close this. |
|
As
|
src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php
Outdated
Show resolved
Hide resolved
| @trigger_error('Not defining "getPublicPath()" method is deprecated since Symfony 4.4 and will not be supported in 5.0.', E_USER_DEPRECATED); | ||
| $publicPath = 'Resources/public'; | ||
| if (!method_exists($bundle, 'getPublicDir')) { | ||
| @trigger_error(sprintf('Not defining "getPublicDir()" method in the "%s" class is deprecated since Symfony 4.4 and will not be supported in 5.0.', get_class($bundle)), E_USER_DEPRECATED); |
There was a problem hiding this comment.
\get_class, as reported by fabbot
|
Thank you @javiereguiluz. |
…ereguiluz) This PR was squashed before being merged into the 4.4 branch (closes #32452). Discussion ---------- [Bundles] Rename getPublicPath() as getPublicDir() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | I'll add this if approved While documenting #31975 (see symfony/symfony-docs#11930) I realized that the `getPublicPath()` method name is not consistent with the rest of Symfony. In Symfony, "path" is usually associated to routes and we use "dir" for things similar to this: * `getCacheDir()` and `getLogdir()` to override Symfony structure (https://symfony.com/doc/current/configuration/override_dir_structure.html) * `binDir`, `configDir`, `srcDir`, `varDir`, `publicDir` in Symfony Flex recipes (https://github.com/symfony/recipes) to override the dir structure So, this PR proposes to rename `getPublicPath()` as `getPublicDir()` Commits ------- 4ab2f99 [Bundles] Rename getPublicPath() as getPublicDir()
While documenting #31975 (see symfony/symfony-docs#11930) I realized that the
getPublicPath()method name is not consistent with the rest of Symfony.In Symfony, "path" is usually associated to routes and we use "dir" for things similar to this:
getCacheDir()andgetLogdir()to override Symfony structure (https://symfony.com/doc/current/configuration/override_dir_structure.html)binDir,configDir,srcDir,varDir,publicDirin Symfony Flex recipes (https://github.com/symfony/recipes) to override the dir structureSo, this PR proposes to rename
getPublicPath()asgetPublicDir()