[ErrorCatcher] Pretty print JSON formatted errors #32359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jul 4, 2019
stof
approved these changes
Jul 4, 2019
src/Symfony/Component/ErrorCatcher/ErrorRenderer/JsonErrorRenderer.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Jul 4, 2019
ogizanagi
approved these changes
Jul 4, 2019
Tobion
reviewed
Jul 4, 2019
src/Symfony/Component/ErrorCatcher/ErrorRenderer/JsonErrorRenderer.php
Outdated
Show resolved
Hide resolved
yceruto
approved these changes
Jul 4, 2019
|
Thank you @javiereguiluz. |
yceruto
added a commit
that referenced
this pull request
Jul 4, 2019
…reguiluz) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorCatcher] Pretty print JSON formatted errors | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | not needed A long string with JSON contents is not very useful to quickly parse the error contents, so I propose to "pretty print" the JSON errors. Commits ------- ab926d2 [ErrorCatcher] Pretty print JSON formatted errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long string with JSON contents is not very useful to quickly parse the error contents, so I propose to "pretty print" the JSON errors.