[Security] Added type-hints to user providers #32353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Jul 3, 2019
| @@ -44,7 +44,7 @@ public function __construct(ManagerRegistry $registry, string $classOrAlias, str | ||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function loadUserByUsername($username) | ||
| public function loadUserByUsername(string $username) |
There was a problem hiding this comment.
💡 These changes to doctrine-bridge 5 break compatibility with security-core 4.4, thus the bump in composer.json. Can be reverted and re-applied later, if you don't want to bump yet.
derrabus
commented
Jul 3, 2019
| @@ -140,11 +137,8 @@ protected function loadUser($username, Entry $entry) | ||
|
|
||
| /** | ||
| * Fetches a required unique attribute value from an LDAP entry. | ||
| * | ||
| * @param Entry|null $entry |
There was a problem hiding this comment.
This @param annotation was obviously lying to us. 🤔
57 tasks
fabpot
approved these changes
Jul 4, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Security] Added type-hints to user providers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A This PR adds type declarations to user provider classes. Commits ------- 62abb70 [Security] Added type-hints to user providers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type declarations to user provider classes.