[Security] Added type-hints to auth providers, tokens and voters #32351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Jul 3, 2019
| @@ -58,7 +58,7 @@ public function getCredentials() | ||
| return $this->credentials; | ||
| } | ||
|
|
||
| public function setAuthenticated($authenticated) | ||
| public function setAuthenticated(bool $authenticated) |
There was a problem hiding this comment.
💡 This change to security-guard 5 breaks compatibility with security-core 4.4, thus the bump in composer.json. Can be reverted and re-applied later, if you don't want to bump yet.
57 tasks
derrabus
commented
Jul 3, 2019
| @@ -83,7 +83,7 @@ public function testRetrieveUserReturnsUserFromTokenOnReauthentication() | ||
| $provider = new DaoAuthenticationProvider($userProvider, $this->getMockBuilder('Symfony\\Component\\Security\\Core\\User\\UserCheckerInterface')->getMock(), 'key', $this->getMockBuilder('Symfony\\Component\\Security\\Core\\Encoder\\EncoderFactoryInterface')->getMock()); | ||
| $reflection = new \ReflectionMethod($provider, 'retrieveUser'); | ||
| $reflection->setAccessible(true); | ||
| $result = $reflection->invoke($provider, null, $token); |
There was a problem hiding this comment.
💡 null shouldn't be a valid argument for the retrieveUser method. The test only worked because the parameter is ignored on the execution path that is tested here.
5e680c2 to
8c46b95
Compare
derrabus
commented
Jul 3, 2019
| @@ -48,7 +48,7 @@ public function __construct(Connection $conn) | ||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function loadTokenBySeries($series) | ||
| public function loadTokenBySeries(string $series) |
There was a problem hiding this comment.
💡 These changes to doctrine-bridge 5 break compatibility with security-core 4.4, thus the bump in composer.json. Can be reverted and re-applied later, if you don't want to bump yet.
fabpot
approved these changes
Jul 4, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2019
…d voters (derrabus) This PR was merged into the 5.0-dev branch. Discussion ---------- [Security] Added type-hints to auth providers, tokens and voters | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A This PR adds type declarations to authentication providers, tokens and voters. Commits ------- 8c46b95 [Security] Added type-hints to auth providers, tokens and voters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type declarations to authentication providers, tokens and voters.