[DomCrawler] fix missing null in phpdoc #32345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fabbot is right here :) |
4c73812 to
ff313e1
Compare
|
was in the train, it won't push it :( :p |
derrabus
reviewed
Jul 3, 2019
| * @param string $baseHref The base href value | ||
| * @param mixed|null $node A Node to use as the base for the crawling | ||
| * @param string|null $uri The current URI | ||
| * @param string|null $baseHref The base href value |
There was a problem hiding this comment.
I'm unsure what our CS rules are about that, but these changes feel a bit redundant… mixed can be literally anything, including null. And the other two parameters already default to null. 😕
There was a problem hiding this comment.
It can be null in the sense that it's optional, so I don't see why we should change the phpdocs. Let's try to limit the changes to phpdocs to the bare minimum. We are spending too much time on that.
There was a problem hiding this comment.
it also allows passing null explicitly (being optional does not mean you always accept null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add missing phpdoc highlighted in #32329 (comment)