Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DependencyInjection] Removed unused field #32306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jul 1, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

A minor issue I discovered while analyzing the DI component for #32238: AnalyzeServiceReferencesPass defines a private field $expressionLanguage that is not used.

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Did you check for other unused property like that?

@ro0NL
Copy link
Contributor

ro0NL commented Jul 2, 2019

Yes xD

@xabbuh xabbuh added this to the 4.2 milestone Jul 2, 2019
@fabpot
Copy link
Member

fabpot commented Jul 3, 2019

Thank you @derrabus.

@fabpot fabpot merged commit 5865140 into symfony:4.2 Jul 3, 2019
fabpot added a commit that referenced this pull request Jul 3, 2019
This PR was merged into the 4.2 branch.

Discussion
----------

[DependencyInjection] Removed unused field

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

A minor issue I discovered while analyzing the DI component for #32238: `AnalyzeServiceReferencesPass` defines a private field `$expressionLanguage` that is not used.

Commits
-------

5865140 Removed unused field.
@derrabus derrabus deleted the bugfix/remove-unused branch July 3, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.