[Ldap] [5.0] add type-hint to interface and implementation #32253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
commented
Jun 28, 2019
| @@ -45,10 +45,10 @@ public function getEntryManager(); | ||
| * Escape a string for use in an LDAP filter or DN. | ||
| * | ||
| * @param string $subject | ||
| * @param string $ignore | ||
| * @param null|string $ignore |
There was a problem hiding this comment.
we pass null values in the test, I think it's safe to say that is nullable.
5043fbf to
0fa7e3c
Compare
derrabus
requested changes
Jun 28, 2019
57 tasks
0fa7e3c to
1306f52
Compare
|
Status: Needs Review |
derrabus
requested changes
Jun 28, 2019
1306f52 to
f95b1ac
Compare
|
Status: Needs Review |
derrabus
approved these changes
Jun 28, 2019
fabpot
requested changes
Jun 29, 2019
f95b1ac to
19d193a
Compare
19d193a to
03f2e90
Compare
fabpot
approved these changes
Jun 29, 2019
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Jun 29, 2019
…on (Simperfit) This PR was merged into the 5.0-dev branch. Discussion ---------- [Ldap] [5.0] add type-hint to interface and implementation | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | Contribute to #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> This adds the type-hint to the Ldap interfaces and implementation Commits ------- 03f2e90 [Ldap] [5.0] add type-hint to interface and implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the type-hint to the Ldap interfaces and implementation