[5.0][Finder] add parameter type-hints #32243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0046e9c to
79f2f2e
Compare
xabbuh
reviewed
Jun 28, 2019
src/Symfony/Component/Finder/Iterator/ExcludeDirectoryFilterIterator.php
Show resolved
Hide resolved
57 tasks
79f2f2e to
1f6c68c
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Finder] docblock fixes | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A This PR provides some docblock fixes found in #32243 Commits ------- 02ee4d0 [Finder] docblock fixes
fabpot
requested changes
Jul 5, 2019
1f6c68c to
7f98903
Compare
fabpot
approved these changes
Jul 8, 2019
|
Thank you @smoench. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [5.0][Finder] add parameter type-hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 | License | MIT | Doc PR | N/A This PR adds parameter type hints to the Finder component. Commits ------- 7f98903 [5.0][Finder] add parameter type-hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parameter type hints to the Finder component.