symfony · nicolas-grekas · Aug 13, 2019 · Aug 4, 2019
diff --git a/src/Symfony/Component/Form/AbstractExtension.php b/src/Symfony/Component/Form/AbstractExtension.php
@@ -50,7 +50,7 @@ abstract class AbstractExtension implements FormExtensionInterface
    /**
     * {@inheritdoc}
     */
-    public function getType($name)
+    public function getType(string $name)
    {
        if (null === $this->types) {
            $this->initTypes();
@@ -66,7 +66,7 @@ public function getType($name)
    /**
     * {@inheritdoc}
     */
-    public function hasType($name)
+    public function hasType(string $name)
    {
        if (null === $this->types) {
            $this->initTypes();
@@ -78,7 +78,7 @@ public function hasType($name)
    /**
     * {@inheritdoc}
     */
-    public function getTypeExtensions($name)
+    public function getTypeExtensions(string $name)
    {
        if (null === $this->typeExtensions) {
            $this->initTypeExtensions();
@@ -92,7 +92,7 @@ public function getTypeExtensions($name)
    /**
     * {@inheritdoc}
     */
-    public function hasTypeExtensions($name)
+    public function hasTypeExtensions(string $name)
    {
        if (null === $this->typeExtensions) {
            $this->initTypeExtensions();

diff --git a/src/Symfony/Component/Form/AbstractRendererEngine.php b/src/Symfony/Component/Form/AbstractRendererEngine.php
@@ -123,7 +123,7 @@ abstract protected function loadResourceForBlockName(string $cacheKey, FormView
     *
     * @see getResourceForBlockHierarchy()
     */
-    private function loadResourceForBlockNameHierarchy(string $cacheKey, FormView $view, array $blockNameHierarchy, $hierarchyLevel): bool
+    private function loadResourceForBlockNameHierarchy(string $cacheKey, FormView $view, array $blockNameHierarchy, int $hierarchyLevel): bool
    {
        $blockName = $blockNameHierarchy[$hierarchyLevel];


diff --git a/src/Symfony/Component/Form/Button.php b/src/Symfony/Component/Form/Button.php
@@ -128,7 +128,7 @@ public function getParent()
     *
     * @throws BadMethodCallException
     */
-    public function add($child, $type = null, array $options = [])
+    public function add($child, string $type = null, array $options = [])
    {
        throw new BadMethodCallException('Buttons cannot have children.');
    }
@@ -138,23 +138,19 @@ public function add($child, $type = null, array $options = [])
     *
     * This method should not be invoked.
     *
-     * @param string $name
-     *
     * @throws BadMethodCallException
     */
-    public function get($name)
+    public function get(string $name)
    {
        throw new BadMethodCallException('Buttons cannot have children.');
    }

    /**
     * Unsupported method.
     *
-     * @param string $name
-     *
     * @return bool Always returns false
     */
-    public function has($name)
+    public function has(string $name)
    {
        return false;
    }
@@ -164,11 +160,9 @@ public function has($name)
     *
     * This method should not be invoked.
     *
-     * @param string $name
-     *
     * @throws BadMethodCallException
     */
-    public function remove($name)
+    public function remove(string $name)
    {
        throw new BadMethodCallException('Buttons cannot have children.');
    }
@@ -184,7 +178,7 @@ public function all()
    /**
     * {@inheritdoc}
     */
-    public function getErrors($deep = false, $flatten = true)
+    public function getErrors(bool $deep = false, bool $flatten = true)
    {
        return new FormErrorIterator($this, []);
    }
@@ -378,7 +372,7 @@ public function handleRequest($request = null)
     *
     * @throws Exception\AlreadySubmittedException if the button has already been submitted
     */
-    public function submit($submittedData, $clearMissing = true)
+    public function submit($submittedData, bool $clearMissing = true)
    {
        if ($this->submitted) {
            throw new AlreadySubmittedException('A form can only be submitted once');