[Security/Core] require libsodium >= 1.0.14 #32169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jun 25, 2019
6eaec4f to
4b40c59
Compare
4b40c59 to
2c234b6
Compare
2c234b6 to
4fed5d3
Compare
rbaarsma
approved these changes
Jun 25, 2019
fabpot
approved these changes
Jun 25, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 25, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Security/Core] require libsodium >= 1.0.14 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32166 | License | MIT | Doc PR | - - bump libsodium to >=1.0.14 - Minimum opscost must be 3, as described in https://wiki.php.net/rfc/libsodium and in https://github.com/jedisct1/libsodium/releases/tag/1.0.15 - ParagonIE_Sodium_Compat [explicitly doesn't implement Argon2](https://github.com/paragonie/sodium_compat#features-excluded-from-this-polyfill), so it makes no sense to check for it. Commits ------- 4fed5d3 [Security/Core] require libsodium >= 1.0.14
Merged
|
@nicolas-grekas The checks for the sodium_compat library are actually needed because the library exposes the functions but has stubs that only throw Exceptions if neither |
|
Seriously, wow. |
|
That seems fair, as long as it's not relying purely on the function checks you're probably OK. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 26, 2019
…rekas) This PR was merged into the 3.4 branch. Discussion ---------- [Security/Core] work around sodium_compat issue | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As reported by @mbabker in #32169 1.0.9 per https://github.com/jedisct1/libsodium/releases/tag/1.0.9 Commits ------- df50685 [Security/Core] work around sodium_compat issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.