add missing return type in User class #32144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jun 24, 2019
chalasr
approved these changes
Jun 25, 2019
|
Good catch, thanks @Tobion. |
chalasr
pushed a commit
that referenced
this pull request
Jun 25, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- add missing return type in User class | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Fixed a missing type in #31996 chasing #17201 Every method in this class had a return type but this method. Commits ------- 7857f2f add missing return type in User class
mkrauser
added a commit
to mkrauser/symfony
that referenced
this pull request
Dec 4, 2019
…tional) attributes are present symfony#32144
mkrauser
added a commit
to mkrauser/symfony
that referenced
this pull request
Dec 4, 2019
…tional) attributes are present symfony#32144
mkrauser
added a commit
to mkrauser/symfony
that referenced
this pull request
Dec 4, 2019
…tional) attributes are present symfony#32144
mkrauser
added a commit
to mkrauser/symfony
that referenced
this pull request
Dec 10, 2019
…tional) attributes are present symfony#32144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a missing type in #31996 chasing #17201
Every method in this class had a return type but this method.