[Mailgun Mailer] fixed issue when using html body #32131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ad6709 to
4f766ba
Compare
Simperfit
approved these changes
Jun 21, 2019
Simperfit
suggested changes
Jun 21, 2019
fabpot
reviewed
Jun 22, 2019
src/Symfony/Component/Mailer/Bridge/Mailgun/Http/Api/MailgunTransport.php
Show resolved
Hide resolved
4f766ba to
9f7ecc5
Compare
9f7ecc5 to
5084d3a
Compare
5084d3a to
afbefe1
Compare
fabpot
approved these changes
Jun 26, 2019
|
Thank you @alOneh. |
fabpot
added a commit
that referenced
this pull request
Jun 26, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Mailgun Mailer] fixed issue when using html body | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I tested the `symfony/mailgun-mailer` and get an issue when using the `api` scheme with a templated email cause we try to manipulate a stream whereas the `Symfony\Component\Mime\Email::getHtmlBody()` could return also a string (in my case it is one). The issue : ``` stream_get_meta_data() expects parameter 1 to be resource, string given ``` Commits ------- afbefe1 [Mailgun Mailer] fixed issue when using html body
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the
symfony/mailgun-mailerand get an issue when using theapischeme with a templated email cause we try to manipulate a stream whereas theSymfony\Component\Mime\Email::getHtmlBody()could return also a string (in my case it is one).The issue :