[Validator] Use LogicException for missing Property Access Component in comparison constraints #32094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in comparison constraints
fabpot
approved these changes
Jun 19, 2019
OskarStark
approved these changes
Jun 20, 2019
OskarStark
reviewed
Jun 20, 2019
| @@ -46,7 +47,7 @@ public function __construct($options = null) | ||
| } | ||
|
|
||
| if (isset($options['propertyPath']) && !class_exists(PropertyAccess::class)) { | ||
| throw new ConstraintDefinitionException(sprintf('The "%s" constraint requires the Symfony PropertyAccess component to use the "propertyPath" option.', \get_class($this))); | ||
| throw new LogicException(sprintf('The "%s" constraint requires the Symfony PropertyAccess component to use the "propertyPath" option.', \get_class($this))); |
There was a problem hiding this comment.
Well, tests are green, no ? 😄
More seriously, it appears that the constructors of the comparison constraints are not tested atm.
ogizanagi
approved these changes
Jun 21, 2019
|
|
|
|
xabbuh
approved these changes
Jun 21, 2019
|
Good catch, thanks @Lctrs. |
fabpot
added a commit
that referenced
this pull request
Jun 22, 2019
… Component in comparison constraints (Lctrs) This PR was merged into the 4.2 branch. Discussion ---------- [Validator] Use LogicException for missing Property Access Component in comparison constraints | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes-ish | New feature? | no | BC breaks? | yes-ish | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A For consistency. Commits ------- 6ac2316 [Validator] Use LogicException for missing Property Access Component in comparison constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency.