[Debug] workaround BC break in PHP 7.3 #32090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything in https://github.com/php/php-src/blob/PHP-7.4/UPGRADING that could use addressing maybe? It seems like nested ternary operators would be in some library somewhere... |
Wouldn't it be enough if we don't upmerge this workaround to 4.x? |
Symfony itself has quite a few. ;-) But a nested ternary should only trigger a |
fabpot
approved these changes
Jun 19, 2019
Simperfit
approved these changes
Jun 19, 2019
|
We can remove in 4, but there's no hurry, and new BC breaks are for 5, that's why I added this comment. |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 19, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Debug] workaround BC break in PHP 7.3 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | https://github.com/symfony/symfony-standard/issues/1138 symfony/website-skeleton#231 | License | MIT | Doc PR | - A new warning has been added in PHP 7.3 that is breaking BC with Symfony, since we turn warnings into exceptions. This PR turns the new warning into a deprecation, so that we will be able to remove the added "if" in 5.0. I noticed a few other similar BC breaks in 7.1 and 7.2, but *unless someone reports that they block them*, I don't think we need to care. - 7.1 A non well formed numeric value encountered E_NOTICE - 7.1 A non-numeric value encountered E_WARNING - 7.2 count() now raises a warning when an invalid parameter is passed. See https://github.com/php/php-src/blob/PHP-7.1/UPGRADING + same in upper branches. Commits ------- d8d43e6 [Debug] workaround BC break in PHP 7.3
This was referenced Jun 26, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new warning has been added in PHP 7.3 that is breaking BC with Symfony, since we turn warnings into exceptions.
This PR turns the new warning into a deprecation, so that we will be able to remove the added "if" in 5.0.
I noticed a few other similar BC breaks in 7.1 and 7.2, but unless someone reports that they block them, I don't think we need to care.
See https://github.com/php/php-src/blob/PHP-7.1/UPGRADING + same in upper branches.