[Messenger] make all stamps final and mark stamp not meant to be sent #32078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
Jun 18, 2019
| @@ -18,7 +18,7 @@ | ||
| * | ||
| * @experimental in 4.3 | ||
| */ | ||
| class TransportMessageIdStamp implements StampInterface | ||
| final class TransportMessageIdStamp implements StampInterface |
There was a problem hiding this comment.
not needed to be sent but could be useful for debugging a message history (changing ID after retry)
a9f5d1d to
452ba34
Compare
nicolas-grekas
approved these changes
Jun 23, 2019
weaverryan
reviewed
Jun 24, 2019
452ba34 to
013904b
Compare
weaverryan
approved these changes
Jun 24, 2019
Tobion
added a commit
that referenced
this pull request
Jun 24, 2019
…nt to be sent (Tobion) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] make all stamps final and mark stamp not meant to be sent | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | Some newer stamps were already final. This makes all of them final. Also marks all stamps that are not meant to be sent using the new `NonSendableStampInterface`. This makes it easier to see which stamps are actually important and required to persist in a queue for certain functionality, like the `BusNameStamp` for the `RoutableMessageBus` Commits ------- 013904b [Messenger] make all stamps final and mark stamp not meant to be sent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some newer stamps were already final. This makes all of them final. Also marks all stamps that are not meant to be sent using the new
NonSendableStampInterface. This makes it easier to see which stamps are actually important and required to persist in a queue for certain functionality, like theBusNameStampfor theRoutableMessageBus