[Messenger] Remove DispatchAfterCurrentBusStamp when message is put on internal queue #32027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
Jun 17, 2019
|
Isn't the better fix to mark the stamp as |
|
I guess we can do both. |
Tobion
approved these changes
Jun 22, 2019
azjezz
approved these changes
Jun 22, 2019
|
Thank you @Nyholm. |
Tobion
added a commit
that referenced
this pull request
Jun 22, 2019
…ge is put on internal queue (Nyholm) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Remove DispatchAfterCurrentBusStamp when message is put on internal queue | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32009 | License | MIT | Doc PR | This will fix #32009. Thank you @brpauwels for the report. I consider it safe to remove the `DispatchAfterCurrentBusStamp` because its meaning disappear after we handled the "current bus". T0: We add the stamp T1: We put the envelope on an internal queue in `DispatchAfterCurrentBusMiddleware` T2: We handle the current bus. T3: We start processing our internal queue. At T3 there we are "after current bus", that is why we dont need the stamp any more. Commits ------- 91f1680 [Messenger] Remove DispatchAfterCurrentBusStamp when message is put on internal queue
|
Thank you for merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #32009.
Thank you @brpauwels for the report.
I consider it safe to remove the
DispatchAfterCurrentBusStampbecause its meaning disappear after we handled the "current bus".T0: We add the stamp
T1: We put the envelope on an internal queue in
DispatchAfterCurrentBusMiddlewareT2: We handle the current bus.
T3: We start processing our internal queue.
At T3 there we are "after current bus", that is why we dont need the stamp any more.