Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[HttpClient] fix closing debug stream prematurely #32011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31985
License MIT
Doc PR -

@ElGecko76 can you please confirm this fixes the issue for you?
I'm not able to reproduce so I can't myself. Thanks.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 12, 2019
@nicolas-grekas nicolas-grekas changed the title [HttpClient] fix closing debug stream prematurely [HttpClient] ensure debug stream is closed properly Jun 12, 2019
@nicolas-grekas nicolas-grekas changed the title [HttpClient] ensure debug stream is closed properly [HttpClient] fix closing debug stream prematurely Jun 12, 2019
@nicolas-grekas
Copy link
Member Author

I managed to reproduce the issue and I confirm the attached patch works.

@fabpot
Copy link
Member

fabpot commented Jun 13, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 21857a1 into symfony:4.3 Jun 13, 2019
fabpot added a commit that referenced this pull request Jun 13, 2019
…-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] fix closing debug stream prematurely

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31985
| License       | MIT
| Doc PR        | -

@ElGecko76 can you please confirm this fixes the issue for you?
I'm not able to reproduce so I can't myself. Thanks.

Commits
-------

21857a1 [HttpClient] fix closing debug stream prematurely
@nicolas-grekas nicolas-grekas deleted the hc-debug branch June 18, 2019 07:23
@fabpot fabpot mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.