Parameterize Mailgun's region #31998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my bad. Implemented the code last week and didn't noticed someone opened another PR |
|
looking at #31897, I think that the approach of this PR is way simpler. Reopening it |
bdd7b45 to
35aac7f
Compare
fabpot
reviewed
Jun 12, 2019
src/Symfony/Component/Mailer/Bridge/Mailgun/Smtp/MailgunTransport.php
Outdated
Show resolved
Hide resolved
762ab8c to
85cd694
Compare
jderusse
commented
Jun 12, 2019
src/Symfony/Component/Mailer/Bridge/Mailgun/Http/Api/MailgunTransport.php
Show resolved
Hide resolved
85cd694 to
7439c8d
Compare
nicolas-grekas
approved these changes
Jun 13, 2019
fabpot
approved these changes
Jun 14, 2019
|
Thank you @jderusse. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Parameterize Mailgun's region | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31810 | License | MIT | Doc PR | TODO Mailgun is available in 2 regions (US and EU), when registering a custom domain, users can choose one of the 2 regions and **have to** use the right the endpoint (see documentation https://documentation.mailgun.com/en/latest/api-intro.html?highlight=smtp.mailgun.org#mailgun-regions). This PR make the endpoint/region configurable. Commits ------- 7439c8d Parameterize Mailgun's region
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailgun is available in 2 regions (US and EU), when registering a custom domain, users can choose one of the 2 regions and have to use the right the endpoint (see documentation https://documentation.mailgun.com/en/latest/api-intro.html?highlight=smtp.mailgun.org#mailgun-regions).
This PR make the endpoint/region configurable.